Remove AVOID_PRECOMPILED from kernel and gac #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not aware of anything or anyone using it recently. If one wants to test GAP without the "precompiled" versions of type1.g and oper1.g, one can use the `-M` command line option. If one really, *really* wants to compile GAP without these, one can either use the `build/gap-nocomp` binary that we are now producing for internal use; or simplify manually modify the source code.
hulpke
approved these changes
May 17, 2021
fingolfin
added
regression
ChrisJefferson
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not aware of anything or anyone using it recently. If one wants to test
GAP without the "precompiled" versions of type1.g and oper1.g, one can use the
-Mcommand line option. If one really, really wants to compile GAP withoutthese, one can either use the
build/gap-nocompbinary that we are nowproducing for internal use; or simplify manually modify the source code.
This should fix #4466 but I'd like to also add a second fix, so please don't merge this yet (but @hulpke feel free to verify if this PR helps with the issue -- note that I am also interested in learning whether the patch in #4466 (comment) helps.