-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for make install
(still somewhat experimental, but ready to be tested by downstream packagers)
#4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: build system
release notes: added
PRs introducing changes that have since been mentioned in the release notes
labels
May 17, 2021
wilfwilson
added
release notes: to be added
PRs introducing changes that should be (but have not yet been) mentioned in the release notes
and removed
release notes: added
PRs introducing changes that have since been mentioned in the release notes
labels
Jun 10, 2021
fingolfin
force-pushed
the
mh/install
branch
2 times, most recently
from
October 18, 2021 09:53
9e88023
to
4df8fbb
Compare
fingolfin
force-pushed
the
mh/install
branch
3 times, most recently
from
October 25, 2021 21:50
7aeb5bd
to
4f542f5
Compare
wilfwilson
reviewed
Oct 27, 2021
fingolfin
force-pushed
the
mh/install
branch
4 times, most recently
from
November 4, 2021 14:21
92a4aca
to
bfb0986
Compare
fingolfin
force-pushed
the
mh/install
branch
2 times, most recently
from
April 22, 2022 11:00
7c8ba2d
to
11e1794
Compare
3 tasks
fingolfin
force-pushed
the
mh/install
branch
2 times, most recently
from
July 11, 2022 20:43
1270aca
to
a7b9c8a
Compare
fingolfin
changed the title
buildsys: add
buildsys: activate Jul 11, 2022
make install
(WIP)make install
, add CI test for it
fingolfin
added
the
release notes: highlight
PRs introducing changes that should be highlighted at the top of the release notes
label
Jul 11, 2022
fingolfin
force-pushed
the
mh/install
branch
7 times, most recently
from
July 14, 2022 10:29
b6794b1
to
a005eba
Compare
This only covers installing GAP itself, so the library, kernel, libgap; but not packages.
ChrisJefferson
approved these changes
Jul 14, 2022
fingolfin
added
release notes: use title
For PRs: the title of this PR is suitable for direct use in the release notes
and removed
release notes: to be added
PRs introducing changes that should be (but have not yet been) mentioned in the release notes
labels
Aug 17, 2022
fingolfin
changed the title
buildsys: activate
Add support for Aug 17, 2022
make install
, add CI test for itmake install
(still somewhat experimental, but ready to be tested by downstream packagers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release notes: highlight
PRs introducing changes that should be highlighted at the top of the release notes
release notes: use title
For PRs: the title of this PR is suitable for direct use in the release notes
topic: build system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this a year ago and never finished. I figured I should post it here, to (a) remind me about it and (b) see if anybody has feedback, or even (c) is willing to help.
Help could range from trying it out and reporting issues as they are encountered (I am sure there are some, perhaps even many, as I didn't finish this), over suggesting things to actually implementing improvements.
Resolves #197
Some TODOs I do recall are these (and the patch also contains some):
make install
GAP somewhere, then try to run it, and also try to build some select GAP packages against itmake install DESTDIR=/tmp/or/whatever
to check thatDESTDIR
support works (see the automake manual for more on DESTDIR)config.h
README.buildsys.md
for some more details, and feel free to ask me for more if you are interestedconfig.h
from most headers; but there are some hold outs: actual configuration choices (see next point); the kernel version (see point after the next); andSYS_IS_64_BIT
gap-config.h
for things likeHPCGAP
orUSE_GASMAN
orUSE_JULIA_GC
. Then again, ideally we may want to share the same headers between regular GAP, HPC-GAP, Julia GAP, ... which would suggest that it'd be better to add these toGAP_CPPFLAGS
(so it'd end up insysinfo.gap
, which would exist separately for each build variant of GAP; and would also be automatically used bygac
this wayGAP_KERNEL_MAJOR_VERSION
andGAP_KERNEL_MINOR_VERSION
should still be common, so perhaps that could be put into a specific header after all...SYS_IS_64_BIT
still relies onSIZEOF_VOID_P
. But I worked hard on not using it in headers, and only one use (inintobj.h
is left). But of course packages use (cvec
,datastructures
,NormalizInterface
). I guess this is another thing we could (should?) define inGAP_CPPFLAGS
.... Or perhaps we can use a trick as in https://stackoverflow.com/a/32717129/928031make install
at allgac
gac
to not use libtool #4746make install
(including how it interacts with the configure--prefix
and DESTDIR -- can be short and point to the automake manual, as this is mostly for packagers who generally are familiar with this)