Collection of miscellaneous small changes ("cleanup")

.github/issue_template.md

@@ -1,5 +1,5 @@
 Please use the following template to submit an issue
-(you may delete lines which are not used). Thank You!
+(you may delete lines which are not used). Thank you!
 
 ### Observed behaviour
 

.github/pull_request_template.md

@@ -1,6 +1,6 @@
 Please use the following template to submit a pull request, filling
 in at least the "Text for release notes" and/or "Further details".
-Thank You!
+Thank you!
 
 # Description
 

CHANGES.md

@@ -352,7 +352,7 @@ The GAP 4.11.1 distribution contains 151 packages, of which 49 have been updated
 - [#3103](https://github.com/gap-system/gap/pull/3103) This fixes [#3097](https://github.com/gap-system/gap/issues/3097), a problem with `Order` of automorphism
     and [#3100](https://github.com/gap-system/gap/issues/3100), a problem with `GroupHomomorphismByImages`
 - [#3392](https://github.com/gap-system/gap/pull/3392) Prevent blist functions that modify an argument in-place (such as `UniteBlist`) from modifying immutable blists
-- [#3522](https://github.com/gap-system/gap/pull/3522) `IsSimpleGroup` does not implies `IsAlmostSimpleGroup` anymore
+- [#3522](https://github.com/gap-system/gap/pull/3522) `IsSimpleGroup` does not imply `IsAlmostSimpleGroup` anymore
 - [#3575](https://github.com/gap-system/gap/pull/3575) Fix bug in calculating x/p for an integer x and permutation p, if p has been 'trimmed'.
 - [#3603](https://github.com/gap-system/gap/pull/3603) Fix bug where the result of `StandardAssociateUnit` could be not a unit.
 - [#3611](https://github.com/gap-system/gap/pull/3611) Fix `StandardAssociateUnit` for polynomial rings to return a polynomial, not an element of the coefficient ring

dev/MODULE-PROPOSAL

@@ -4,7 +4,7 @@ A module is a part of GAP that
   - consists of a discrete set of files 
 	[unless there is a very good reason]
   - has a well-defined set of authors/maintainers.
-  - get credited separately (see below)
+  - gets credited separately (see below)
  Typical examples would be:
  - Rational functions
  - Lie Algebras

dev/MODULES

@@ -239,7 +239,7 @@ Authors:     Bettina Eick
 Maintainers: Werner Nickel
 Description: This module contains an algorithm to determine the automorphism
              group of a finite pc group. The implementation follows the ideas
-             of Micheal Smith.
+             of Michael Smith.
 
 Name:        Twocohomology and extensions of finite pc groups
 Proposer:    Bettina Eick
@@ -322,7 +322,7 @@ Authors:     Andrew Solomon, Robert F. Morse
 Maintainer:  Robert F. Morse
 Description: This library code computes congruences for a set with one 
              binary operator. Faster methods are used when 
-	     associativity is known.
+             associativity is known.
 
 Name:        Semigroup relations
 Proposer:    Robert F. Morse 21-May-01
@@ -376,16 +376,16 @@ Authors:     Burkhard Hšfling
 Description: This set of files provides the implementation of system dependent
              GAP functions and a user interface to run GAP under MacOS
 
-Name: 	Identification of Galois groups
-Proposer: 	Alexander Hulpke
-Seconder: 	Frank Lübeck (May 4, 2003), Joachim Neub"user (May 5, 2003)
-Files: 	galois.g*
-Author&Maintainer: 	Alexander Hulpke
-Description:	 functionality for determining the permutation isomorphism type of a Galois group.
+Name:        Identification of Galois groups
+Proposer:    Alexander Hulpke
+Seconder:    Frank Lübeck (May 4, 2003), Joachim Neubüser (May 5, 2003)
+Files:       galois.g*
+Author&Maintainer: Alexander Hulpke
+Description: functionality for determining the permutation isomorphism type of a Galois group.
 
 Name:        Characters and Character Degrees of certain solvable groups
 Proposer:    Thomas Breuer
-Seconder:    Frank Lübeck (July 15, 2003), Joachim Neub"user (July 15, 2003)
+Seconder:    Frank Lübeck (July 15, 2003), Joachim Neubüser (July 15, 2003)
 Files:       lib/ctblsolv.gd, lib/ctblsolv.gi
 Authors:     Hans Ulrich Besche, Thomas Breuer
 Maintainer:  Thomas Breuer
@@ -397,7 +397,7 @@ Description: Computation of irreducible character degrees of solvable groups,
 
 Name:        Possible Permutation Characters
 Proposer:    Thomas Breuer
-Seconder:    Frank Lübeck (July 31, 2003), Joachim Neub"user (June 17, 2003)
+Seconder:    Frank Lübeck (July 31, 2003), Joachim Neubüser (June 17, 2003)
 Files:       lib/ctblpope.gd, lib/ctblpope.gi,
              sections ``Possible Permutation Characters'' and
              ``Computing Possible Permutation Characters'' in
@@ -410,7 +410,7 @@ Description: Computation of characters that have certain properties of
 
 Name:        Monomiality Questions
 Proposer:    Thomas Breuer
-Seconder:    Frank Lübeck (July 31, 2003), Joachim Neub"user (June 17, 2003)
+Seconder:    Frank Lübeck (July 31, 2003), Joachim Neubüser (June 17, 2003)
 Files:       lib/ctblmono.gd, lib/ctblmono.gi, doc/build/ctblmono.msk,
              tst/ctblmono.tst
 Authors:     Thomas Breuer, Erzsébet Horváth
@@ -419,7 +419,7 @@ Description: Monomiality of finite (solvable) groups and their characters
 
 Name:        Possible Class Fusions, Possible Power Maps
 Proposer:    Thomas Breuer
-Seconder:    Frank Lübeck (July 31, 2003), Joachim Neub"user (June 17, 2003)
+Seconder:    Frank Lübeck (July 31, 2003), Joachim Neubüser (June 17, 2003)
 Files:       lib/ctblmaps.gd, lib/ctblmaps.gi, doc/build/ctblmaps.msk
 Authors:     Thomas Breuer
 Maintainer:  Thomas Breuer

dev/listarith.tex

@@ -123,7 +123,7 @@ \subsection{In vector.c and vecffe.c}
 
 \section{XTNum extended despatch}
 
-XTNum is defined in lists.c. It's behaviour is controlled by entries
+XTNum is defined in lists.c. Its behaviour is controlled by entries
 in the IsXTNumListFuncs jump table. These are boolean (C style)
 unctions, possibly defined for types from \verb|FIRST_REAL_TNUM| up to
 \verb|LAST_REAL_TNUM|. Each one is tried in reverse TNUM order, with
@@ -258,7 +258,7 @@ \section{Determining the Type of Plists}
 
 What is relevant for our purposes, is that this code, taking advantage
 of the information already stored about the list, walks the structure
-of it, as far as necessary to determine it's ``transient'' TNUM (ie
+of it, as far as necessary to determine its ``transient'' TNUM (ie
 the TNUM that it really deserves, but which might not be storable
 thanks to the presence of mutable subobjects) storing as much
 information along the way as it can. After that, the type is just

dev/modules.txt

@@ -5,7 +5,7 @@ also put in a file `dev/modules.txt'
 Modularization of GAP
 ======================
 
-There are three levels of ``separateness'', that are roughly conatined in
+There are three levels of ``separateness'', that are roughly contained in
 each other:
 The first is a purely software engineering level of ``Modules''. A module is
 a piece of code which provides certain functionality via a defined set of

hpcgap/lib/filter.gi

@@ -24,7 +24,7 @@
 ##  position of this filter in the global FILTERS list.
 ##  <P/>
 ##  Note that not every <C>filter</C> for which <C>IsFilter(filter)</C>
-##  returns <C>true</C> has an ID, only elementary filters do.
+##  returns <K>true</K> has an ID, only elementary filters do.
 ##  </Description>
 ##  </ManSection>
 ##  <#/GAPDoc>

lib/bitfields.gd

@@ -53,13 +53,13 @@
 ##  corresponding to the width 1 fields.
 ##  <List> <Mark><C>booleanGetters</C></Mark> <Item>if the <M>i</M>th position of
 ##  this list is set, it contains a function which extracts the <M>i</M>th
-##  field (which will have width one) and returns <C>true</C> if it contains 1
-##  and <C>false</C> if it contains 0</Item>
+##  field (which will have width one) and returns <K>true</K> if it contains 1
+##  and <K>false</K> if it contains 0</Item>
 ##  <Mark><C>booleanSetters</C></Mark> <Item>if the <M>i</M>th position of
 ##  this list is set, it contains a function of two arguments. The first
-##  argument is a packed value, the second is <C>true</C> or <C>false</C>. It returns a
+##  argument is a packed value, the second is <K>true</K> or <K>false</K>. It returns a
 ##  new packed value in which the <M>i</M>th field is set to 1 if the second
-##  argument was <C>true</C> and 0 if it was <C>false</C>. Behaviour for any
+##  argument was <K>true</K> and 0 if it was <K>false</K>. Behaviour for any
 ##  other value is undefined.</Item></List>
 ##  </Description>
 ##  </ManSection>

lib/filter.gi

@@ -24,7 +24,7 @@
 ##  position of this filter in the global FILTERS list.
 ##  <P/>
 ##  Note that not every <C>filter</C> for which <C>IsFilter(filter)</C>
-##  returns <C>true</C> has an ID, only elementary filters do.
+##  returns <K>true</K> has an ID, only elementary filters do.
 ##  </Description>
 ##  </ManSection>
 ##  <#/GAPDoc>

lib/gpprmsya.gi

@@ -673,14 +673,8 @@ InstallMethod(IsNaturalAlternatingGroup,"knows size",true,[IsPermGroup
 end );
 
 InstallMethod(IsNaturalAlternatingGroup,"comprehensive",true,[IsPermGroup],0,
-function( grp )
-  if 0 = NrMovedPoints(grp)  then
-    return IsTrivial(grp);
-  else
-    return PermgpContainsAn(grp)=true and
-      ForAll(GeneratorsOfGroup(grp),i->SignPerm(i)=1);
-  fi;
-end );
+G -> IsTrivial(G) or
+  ForAll(GeneratorsOfGroup(G),i->SignPerm(i)=1) and PermgpContainsAn(G)=true);
 
 #############################################################################
 ##
@@ -705,14 +699,8 @@ InstallMethod(IsNaturalSymmetricGroup,"knows size",true,[IsPermGroup
 end );
 
 InstallMethod(IsNaturalSymmetricGroup,"comprehensive",true,[IsPermGroup],0,
-function( grp )
-  if 0 = NrMovedPoints(grp)  then
-    return IsTrivial(grp);
-  else
-    return PermgpContainsAn(grp)=true and
-      ForAny(GeneratorsOfGroup(grp),i->SignPerm(i)=-1);
-  fi;
-end );
+G -> IsTrivial(G) or
+  ForAny(GeneratorsOfGroup(G),i->SignPerm(i)=-1) and PermgpContainsAn(G)=true);
 
 #############################################################################
 ##

lib/grppcaut.gi

@@ -786,7 +786,7 @@ end;
 # construct subgroup of GL that stabilizes the spaces given and fixes the
 # listed spaceorbits.
 
-# auxillary
+# auxiliary
 RedmatSpanningIndices:=function(gens)
 local bas,n,one,new,a,b,g;
   n:=Length(gens[1]);

lib/matrix.gi

@@ -1551,7 +1551,7 @@ InstallMethod( DeterminantMatDestructive,"nonprime residue rings",
 ##  Mahajan and Vinay \cite{MV97}.
 ##
 ##  The run time is $O(n^4)$
-##  Auxillary storage size $n^2+n + C$
+##  Auxiliary storage size $n^2+n + C$
 ##
 ##  Our implementation has two runtime optimizations (both noted
 ##  by Mahajan and Vinay)
@@ -1560,9 +1560,9 @@ InstallMethod( DeterminantMatDestructive,"nonprime residue rings",
 ##    2. Prefix property is maintained allowing for a pruning of many
 ##       vertices at each level
 ##
-##  and two auxillary storage size optimizations
+##  and two auxiliary storage size optimizations
 ##    1. only the upper triangular and diagonal portion of the
-##       auxillary storage is used.
+##       auxiliary storage is used.
 ##    2. Level information storage is reused (2 levels).
 ##
 ##  This code was implemented by:

lib/morpheus.gd

@@ -364,7 +364,7 @@ DeclareGlobalFunction("MorMaxFusClasses");
 ##  <Mark><C>condition</C></Mark>
 ##  <Item>
 ##   A function that will be applied to the homomorphism and must return
-##  <C>true</C> for the homomorphism to be accepted.
+##  <K>true</K> for the homomorphism to be accepted.
 ##  </Item>
 ##  </List>
 ##  <P/>

lib/oper.g

@@ -1244,9 +1244,9 @@ end );
 ##  this incremental rank (see&nbsp;<Ref Sect="Filters"/>),
 ##  </Item>
 ##  <Item> If the argument <A>mutable</A> is the string <C>"mutable"</C> or
-##  the boolean <C>true</C>, then the values of the attribute are mutable.
+##  the boolean <K>true</K>, then the values of the attribute are mutable.
 ##  </Item>
-##  <Item> If the argument <A>mutable</A> is the boolean <C>false</C>, then
+##  <Item> If the argument <A>mutable</A> is the boolean <K>false</K>, then
 ##  the values of the attribute are immutable.
 ##  </Item>
 ##  </List>

lib/sgpres.gi

@@ -3579,7 +3579,7 @@ local DATA,rels,i,j,w,f,r,s,fam,new,ri,a,offset,p,rset,re,start,stack,pres,
         if warn and Length(s)>100*Sum(rels,Length) then
           warn:=false;
           Error(
-            "Trying to eliminate all auxillary generators might cause the\n",
+            "Trying to eliminate all auxiliary generators might cause the\n",
             "size of the presentation to explode. Proceed at risk!");
         fi;
       od;

lib/system.g

@@ -536,7 +536,7 @@ end);
 ##
 ##  <Description>
 ##  tests whether &GAP; is running on Mac OS X. Note that on Mac OS X, also
-##  <Ref Func="ARCH_IS_UNIX"/> will be <C>true</C>.
+##  <Ref Func="ARCH_IS_UNIX"/> will be <K>true</K>.
 ##  </Description>
 ##  </ManSection>
 ##  <#/GAPDoc>

lib/teaching.g

@@ -325,8 +325,8 @@ DeclareGlobalFunction("CheckDigitTestFunction");
 ##  <Description>
 ##  These functions can be used to compute, or check, check digits for some
 ##  everyday items. In each case what is submitted as input is either the number
-##  with check digit (in which case the function returns <C>true</C> or
-##  <C>false</C>), or the number without check digit (in which case the function
+##  with check digit (in which case the function returns <K>true</K> or
+##  <K>false</K>), or the number without check digit (in which case the function
 ##  returns the missing check digit). The number can be specified as integer, as
 ##  string (for example in case of leading zeros) or as a sequence of arguments,
 ##  each representing a single digit.

lib/test.gi

@@ -346,10 +346,10 @@ end);
 ##  <Item>A <C>#@if</C> allows to conditionally skip parts of the test input depending on
 ##  the value of a boolean expression. The exact behavior is done as follows:
 ##  <P/>
-##  If the &GAP; expression <C>EXPR</C> evaluates to <C>true</C>, then the lines after the
+##  If the &GAP; expression <C>EXPR</C> evaluates to <K>true</K>, then the lines after the
 ##  <C>#@if</C> are used until either a <C>#@else</C> or <C>#@fi</C> is
 ##  reached. If a <C>#@else</C> is present then the code after the <C>#@else</C>
-##  is used if and only if <C>EXPR</C> evaluated to <C>false</C>. Finally,
+##  is used if and only if <C>EXPR</C> evaluated to <K>false</K>. Finally,
 ##  once <C>#endif</C> is reached, evaluation continues normally.
 ##  </Item>
 ##  </List>

lib/type.gd

@@ -76,8 +76,8 @@ DeclareGlobalFunction( "TypeOfOperation" );
 ##  <Func Name="IsCategory" Arg='object'/>
 ##
 ##  <Description>
-##  returns <C>true</C> if <A>object</A> is a category
-##  (see&nbsp;<Ref Sect="Categories"/>), and <C>false</C> otherwise.
+##  returns <K>true</K> if <A>object</A> is a category
+##  (see&nbsp;<Ref Sect="Categories"/>), and <K>false</K> otherwise.
 ##  <P/>
 ##  Note that &GAP; categories are <E>not</E> categories in the usual mathematical
 ##  sense.
@@ -97,8 +97,8 @@ DeclareGlobalFunction( "IsCategory" );
 ##  <Func Name="IsRepresentation" Arg='object'/>
 ##
 ##  <Description>
-##  returns <C>true</C> if <A>object</A> is a representation
-##  (see&nbsp;<Ref Sect="Representation"/>), and <C>false</C> otherwise.
+##  returns <K>true</K> if <A>object</A> is a representation
+##  (see&nbsp;<Ref Sect="Representation"/>), and <K>false</K> otherwise.
 ##  </Description>
 ##  </ManSection>
 ##  <#/GAPDoc>
@@ -116,8 +116,8 @@ DeclareGlobalFunction( "IsRepresentation" );
 ##  <Func Name="IsAttribute" Arg='object'/>
 ##
 ##  <Description>
-##  returns <C>true</C> if <A>object</A> is an attribute
-##  (see&nbsp;<Ref Sect="Attributes"/>), and <C>false</C> otherwise.
+##  returns <K>true</K> if <A>object</A> is an attribute
+##  (see&nbsp;<Ref Sect="Attributes"/>), and <K>false</K> otherwise.
 ##  </Description>
 ##  </ManSection>
 ##  <#/GAPDoc>
@@ -135,8 +135,8 @@ DeclareGlobalFunction( "IsAttribute" );
 ##  <Func Name="IsProperty" Arg='object'/>
 ##
 ##  <Description>
-##  returns <C>true</C> if <A>object</A> is a property
-##  (see&nbsp;<Ref Sect="Properties"/>), and <C>false</C> otherwise.
+##  returns <K>true</K> if <A>object</A> is a property
+##  (see&nbsp;<Ref Sect="Properties"/>), and <K>false</K> otherwise.
 ##  </Description>
 ##  </ManSection>
 ##  <#/GAPDoc>

lib/vspcmat.gi

@@ -190,11 +190,8 @@ InstallMethod( Coefficients,
     fi;
 
     # Preset the coefficients list with zeroes.
-    zero    := Zero( v[1][1] );
-    coeff   := [];
-    for i in [ 1 .. Length( vectors ) ] do
-      coeff[i]:= zero;
-    od;
+    zero:= Zero( v[1][1] );
+    coeff:= ListWithIdenticalEntries( Length( vectors ), zero );
 
     # Compute the coefficients of the basis vectors.
     m:= Length( v );

lib/vspcrow.gi

@@ -315,8 +315,7 @@ InstallMethod( Coefficients,
     fi;
 
     # Preset the coefficients list with zeroes.
-    zero:= Zero( v[1] );
-    coeff:= List( vectors, x -> zero );
+    coeff:= ListWithIdenticalEntries( Length( vectors ), Zero( v[1] ) );
 
     # Compute the coefficients of the base vectors.
     v:= ShallowCopy( v );

src/gap.c

@@ -590,8 +590,8 @@ static Obj FuncWindowCmd(Obj self, Obj args)
     {
       tmp = ELM_LIST( args, i );
       if (!IS_INTOBJ(tmp) && !IsStringConv(tmp)) {
-          ErrorMayQuit("WindowCmd: %d. argument must be a string or integer "
-                       "(not a %s)",
+          ErrorMayQuit("WindowCmd: the argument in position %d must be a "
+                       "string or integer (not a %s)",
                        i, (Int)TNAM_OBJ(tmp));
           SET_ELM_PLIST(args, i, tmp);
       }
@@ -1445,7 +1445,7 @@ StructInitInfo * InitInfoGap ( void )
 **  function is used for both starting and restoring.
 **
 **  `InitLibrary': This function creates objects,  gvar and rnam number,  and
-**  does  assignments of auxillary C   variables (for example, pointers  from
+**  does  assignments of auxiliary C   variables (for example, pointers  from
 **  objects, length of hash lists).  This function is only used for starting.
 **
 **  `PostRestore': Everything in  `InitLibrary' execpt  creating objects.  In

tst/mockpkg/doc/about.tex

@@ -8,7 +8,7 @@
 
 This is a mock package to be used to test {\GAP} library code
 related to {\GAP} packages, for example to validate `PackageInfo.g`
-files. Clearly, it's not available anywhere, and it has it's `ArchiveURL' set
+files. Clearly, it's not available anywhere, and it has its `ArchiveURL' set
 to `Concatenation( ~.PackageWWWHome, "/", ~.PackageName, "-", ~.Version )'
 only for testing purposes.