Bug fixes in NormalSubgroups and PrintCSV #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be taken care of when acting on the cohomology group.
|
Out of interest, what is the issue with |
|
@ChrisJefferson I was using Int to test whether a string is an integer (relying on an undocumented feature to return `fail' otherwise which does not work any longer with recent changes), so I need to check the argument myself. (The fix is not in Int but in a call to Int). |
hulpke
added a commit
that referenced
this pull request
Jan 8, 2016
Bug fixes in NormalSubgroups and PrintCSV. (There is an accidental addition and later delete which somehow made it into the history but not into the files.)
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both should go into the 4.8 branch as well