-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admit non-fields as left acting domains for free (associative or Lie) algebras, and fix the zero-dimensional case #4245
Merged
fingolfin
merged 3 commits into
gap-system:master
from
laurentbartholdi:grading-of-free-modules
Feb 9, 2021
Merged
Admit non-fields as left acting domains for free (associative or Lie) algebras, and fix the zero-dimensional case #4245
fingolfin
merged 3 commits into
gap-system:master
from
laurentbartholdi:grading-of-free-modules
Feb 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Feb 4, 2021
lib/alglie.gi
Outdated
@@ -3752,8 +3752,9 @@ InstallGlobalFunction( FreeLieAlgebra, function( arg ) | |||
od; od; | |||
od; | |||
od; | |||
return VectorSpace( R, List( B[degree], | |||
p->ElementOfMagmaRing( F, zero, [ one ], [ p[3] ] ))); | |||
if degree<1 then B := []; else B := B[degree]; fi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is something wrong with indentation here
Could you please also provide a test case, say in |
OK, I pushed a test file.
Indentation: there was a problem with tabs vs spaces in my file.
…On Fri, Feb 5, 2021 at 12:03 AM Max Horn ***@***.***> wrote:
Could you please also provide a test case, say in tst/testbugfix/?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4245 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARAQUBMKY7RZBTLCNWH2KTS5MRT3ANCNFSM4XDQLIDQ>
.
--
Laurent Bartholdi laurent.bartholdi<at>gmail<dot>com
Mathematisches Institut, Georg-August Universität zu Göttingen
Bunsenstrasse 3-5, D-37073 Göttingen, Germany
|
wilfwilson
added
kind: bug
Issues describing general bugs, and PRs fixing them
kind: bug: unexpected error
Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them
release notes: to be added
PRs introducing changes that should be (but have not yet been) mentioned in the release notes
topic: library
labels
Feb 8, 2021
fingolfin
approved these changes
Feb 9, 2021
Thank you |
ThomasBreuer
changed the title
Fix zero-dimensional hom_component and non-field left acting ring
Free (associative or Lie) algebras: admit non-fields as left acting domains, fixed the zero-dimensional case.
Feb 16, 2021
ThomasBreuer
added
release notes: added
PRs introducing changes that have since been mentioned in the release notes
and removed
release notes: to be added
PRs introducing changes that should be (but have not yet been) mentioned in the release notes
labels
Feb 16, 2021
fingolfin
changed the title
Free (associative or Lie) algebras: admit non-fields as left acting domains, fixed the zero-dimensional case.
Admit non-fields as left acting domains for free (associative or Lie) algebras, and fix the zero-dimensional case
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: bug: unexpected error
Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them
kind: bug
Issues describing general bugs, and PRs fixing them
release notes: added
PRs introducing changes that have since been mentioned in the release notes
topic: library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems:
which is fixed by supplying a zero element in case there are no generators to the component; and
granted, there is now little working functionality with these left modules; but I'm working on improving this situation within a package.