Improve errors messages for various set operations (AddSet, UniteSet, ...)
#4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AddSet, RemoveSet, UniteSet, IntersectSet, SubtractSet now print a helpful error if the first argument is not mutable, or not a set.
fingolfin
force-pushed
the
mh/friendlier-set-operations
branch
from
5f4fdd4
to
2f8fed3
Compare
fingolfin
added
kind: enhancement
wilfwilson
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
I think this is fine, and sufficient to close #3597
Issue #3597 raises ideas about more general solutions to improving error messages in the case that incorrect arguments are given, but I think that's beyond the scope of the issue, and anyway, it's a big topic and one that's not going to be forgotten when #3597 in particular gets closed.
ThomasBreuer
changed the title
AddSet, UniteSet, ...).
ThomasBreuer
added
release notes: added
fingolfin
changed the title
AddSet, UniteSet, ...).AddSet, UniteSet, ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddSet, RemoveSet, UniteSet, IntersectSet, SubtractSet now print a helpful error if the first argument is not mutable, or not a set.
I would argue that this resolves #3597 but not everybody might agree with that? @ChrisJefferson ?