Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some unexpected error when inverting or computing random elements of algebraic extensions of finite fields of size > 256 #4108

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix some unexpected error when inverting or computing random elements of algebraic extensions of finite fields of size > 256 #4108

merged 1 commit into from
Oct 15, 2020

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Sep 3, 2020 •
edited
Loading

The code for algebraic extensions passed fam!.rchar to ImmutableVector;
but that value was 0 if the characteristic exceeded 256.

This is an alternative to PR #4107.

Close #4107

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Sep 3, 2020
@fingolfin
Avoid calling ImmutableVector(0, v)
8b13d1c 
The code for algebraic extensions passed fam!.rchar to ImmutableVector;
but that value was 0 if the characteristic exceeded 256.
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.0e-05%) to 93.728% when pulling 8b13d1c on fingolfin:mh/no-rchar into 9723019 on gap-system:master.

@fingolfin fingolfin merged commit 4a11584 into gap-system:master Oct 15, 2020
@fingolfin fingolfin deleted the mh/no-rchar branch October 15, 2020 11:25
@PaulaHaehndel PaulaHaehndel self-assigned this Feb 16, 2021
@PaulaHaehndel PaulaHaehndel added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 16, 2021
@PaulaHaehndel PaulaHaehndel removed their assignment Feb 16, 2021
@olexandr-konovalov olexandr-konovalov mentioned this pull request Feb 19, 2021
Closed
@olexandr-konovalov olexandr-konovalov mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulpke hulpke hulpke approved these changes

Assignees
No one assigned
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fingolfin @coveralls @hulpke @PaulaHaehndel