Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an infinite loop in series refinement if large factors could not be refined, improve documentation of IsAutomorphismGroup and fix typo in option name of IsomorphismSimplifiedFpGroup #4076

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Fix an infinite loop in series refinement if large factors could not be refined, improve documentation of IsAutomorphismGroup and fix typo in option name of IsomorphismSimplifiedFpGroup #4076

merged 3 commits into from
Jul 20, 2020

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Jul 16, 2020 •
edited
Loading

Attempted series refinement would not terminate if large factors could not
be refined.
(And two small changes that do not merit their own PR)

@hulpke
FIX: Infinite loop in series refinement
701621f 
Attempted series refinement would not terminate if large factors could not
be refined.
@hulpke hulpke added kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes priority: high backport-to-4.11 labels Jul 16, 2020
@coveralls
Copy link

coveralls commented Jul 16, 2020 •
edited
Loading

Coverage Status

Coverage increased (+9.0e-05%) to 84.882% when pulling 77141e7 on hulpke:additions into 7995b72 on gap-system:master.

@fingolfin fingolfin merged commit 15f056c into gap-system:master Jul 20, 2020
@fingolfin fingolfin changed the title FIX: Infinite loop in series refinement Fix an infinite loop in series refinement if large factors could not be refined Jul 30, 2020
@PaulaHaehndel PaulaHaehndel self-assigned this Feb 16, 2021
@PaulaHaehndel PaulaHaehndel changed the title Fix an infinite loop in series refinement if large factors could not be refined Fix an infinite loop in series refinement if large factors could not be refined, improve documentation of IsAutomorphismGroup and fix typo in Option name of IsomorphismSimplifiedFpGroup Feb 16, 2021
@PaulaHaehndel PaulaHaehndel changed the title Fix an infinite loop in series refinement if large factors could not be refined, improve documentation of IsAutomorphismGroup and fix typo in Option name of IsomorphismSimplifiedFpGroup Fix an infinite loop in series refinement if large factors could not be refined, improve documentation of IsAutomorphismGroup and fix typo in option name of IsomorphismSimplifiedFpGroup Feb 16, 2021
@PaulaHaehndel PaulaHaehndel added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 16, 2021
@PaulaHaehndel PaulaHaehndel removed their assignment Feb 16, 2021
@olexandr-konovalov olexandr-konovalov mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
backport-to-4.11-DONE kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) priority: high release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hulpke @coveralls @fingolfin @PaulaHaehndel