-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For the buildsystem now only .d files that exist are included #4026
Conversation
1a7afdb
to
09087b0
Compare
09087b0
to
2417390
Compare
I added a bunch of tests. They involving using the name |
@@ -290,7 +290,7 @@ endif | |||
DEPFILES = $(patsubst %,gen/deps/%.d,$(SOURCES)) | |||
|
|||
# Include the dependency tracking files, skip any missing ones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the comment already that we "skip any missing ones", but that wasn't true anymore with my previous refactoring of the buildsystem; this PR restores the behavior described in the comment
Fixes #4025
Of course ideally we'd also have tests for this... Here is one way we could do that: we could have a Travis test which uses an out-of-tree build where we do
make clean
beforemake
but after configure. That'll trigger the bug as I fixed it.We could of course do more thing:
make
, remove one file *.d file then runmake
and verify it is being recreatedmake
doesn't run into an error)make ; make
does not regenerate gap or anything (say, by testing that the secondmake
has no output)