Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etc/Makefile.gappkg: various improvements #4016

Merged
merged 1 commit into from
May 12, 2020

Conversation

fingolfin
Copy link
Member

  • built-in autoconf support for packages that need a complex configure script;
    this adds rules which re-run autoconf or autoheader as needed, and to regenerate
    various files automatically; sometimes this can be undesired, then it can be
    turned off by setting the (environment) variable MAINTAINER_MODE to "no"
  • support assembler ".s" source files (via C compiler)
  • honor user supplied CFLAGS, CXXFLAGS, LDFLAGS
  • little hack to ensure that when using GAP 4.9, the GAP src directory is in
    the list of include paths (as it is automatically with GAP 4.10 and later),
    so that #include "compiled.h" works

This covers #3973 partially.

This should be backported to stable-4.11.

I'll also submit PRs to (more) packages using this file to convince them to update

- built-in autoconf support for packages that need a complex configure script;
  this adds rules which re-run autoconf or autoheader as needed, and to regenerate
  various files automatically; sometimes this can be undesired, then it can be
  turned off by setting the (environment) variable MAINTAINER_MODE to "no"
- support assembler ".s" source files (via C compiler)
- honor user supplied CFLAGS, CXXFLAGS, LDFLAGS
- little hack to ensure that when using GAP 4.9, the GAP src directory is in
  the list of include paths (as it is automatically with GAP 4.10 and later),
  so that `#include "compiled.h"` works
@fingolfin fingolfin added topic: build system topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker) backport-to-4.11 labels May 7, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+5.0e-05%) to 84.373% when pulling a34f002 on fingolfin:mh/Makefile.gappkg into 63d2b80 on gap-system:master.

@fingolfin fingolfin merged commit a93b040 into gap-system:master May 12, 2020
@fingolfin fingolfin deleted the mh/Makefile.gappkg branch May 12, 2020 11:02
@fingolfin
Copy link
Member Author

Backported to stable-4.11 in commit bbaab82

@PaulaHaehndel PaulaHaehndel added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Feb 16, 2021
@ThomasBreuer ThomasBreuer added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-4.11-DONE release notes: added PRs introducing changes that have since been mentioned in the release notes topic: build system topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants