Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: GCD for rational polynomials #3980

Merged
merged 1 commit into from
Apr 23, 2020
Merged

FIX: GCD for rational polynomials #3980

merged 1 commit into from
Apr 23, 2020

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Apr 22, 2020 •
edited
Loading

Use of modular results by Chinese remainder. Code was included in a wrong way
with missing argument that led to syntax error. Rare case, as this situation usually can be handled with by heuristics.

This fixes an error reported by Willem de Graaf

@hulpke
FIX: GCD for rational polynomials
b5e5e21 
Use of modular results by Chinese remainder. Code was included in wrong way
that led to syntax error. Rare case, as usually fixed by heuristics.
@hulpke hulpke added kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them backport-to-4.11 labels Apr 22, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 84.366% when pulling b5e5e21 on hulpke:additions into 86c4135 on gap-system:master.

@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Apr 23, 2020
@fingolfin fingolfin added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Apr 23, 2020
@hulpke hulpke merged commit 7941f3d into gap-system:master Apr 23, 2020
fingolfin pushed a commit that referenced this pull request May 12, 2020
@hulpke @fingolfin
FIX: GCD for rational polynomials (#3980)
e261ac3 
Use of modular results by Chinese remainder. Code was included in wrong way
that led to syntax error. Rare case, as usually fixed by heuristics.
@fingolfin
Copy link
Member

Backported to stable-4.11 in commit e261ac3

@ThomasBreuer ThomasBreuer added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 17, 2021
@olexandr-konovalov olexandr-konovalov mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
backport-to-4.11-DONE kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hulpke @coveralls @fingolfin @ThomasBreuer