-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the missing perfect groups of order up to a million #3925
Conversation
This needs to be rebased on latest master: package bootstrap was temporarily broken because we moved file downloads to its own subdomain; now, of course we also set up a redirect, but it turns out we didn't configure Sorry for the inconvenience. Also, 10% or so of Travis builds currently randomly fail because the downloads from gap-system.org alternate between blazing fast (5 seconds to download package tarball) to incredible slow (> 40 minutes do download). We are working during the ongoing virtual reality GAP Days on addressing this in some way. |
Thank you for the explanation. I observed this weird behavior and was wondering whether anyone was aware of it. I suspect you have good ideas what to do about it and won't need me to second-guess possible workarounds. |
At the core, it seems that the VM the University of St Andrews gives us to host the GAP web server is flaky (for many months now, it has been offline for a few seconds or minutes, multiple times per day); and recently, the bandwidth breaks down frequently, too. I have no idea what exactly is the cause, but in the end, it doesn't matter. Right now, we are considering to just move the "default" downloads to the GitHub release system, which has been very reliable for us so far, and use the St Andrews only as backup. In addition, I may be able to offer hosting in Kaiserslautern, but maybe only after the Corona pandemic, as right now it is difficult to coordinate this with the computer admins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A typos and a remark on the docs, but overall this is fine and of course a great addition to GAP!
@hulpke this still has the "do not merge" label; on purpose? |
Yes, the "Do not merge" is since I still want to run correctness tests. Aded, Oct 1: Tests have run. I found a bug and this is fixed and the results corrected/rechecked. |
These seem to be the relevant commits:
and
|
@fingolfin Perfect (pun intened). Thank you! I'll add a remark. |
@hulpke One more minor remark:
whereas the new variant forces one to check for
|
@ThomasBreuer The issue of "available perfect groups" was much more a concern with the holes in the library. OTOH, the old convention of The new behavior also is more consistent with the other group libraries, none of which distinguishes "Groups" from "LibraryGroups". What probably however should be done with this change is to move |
@hulpke Well, this is how I found the hypothetical problem with the changed behaviour of |
0f7f687
to
db5fac5
Compare
Remove the `notAvailable` component of `PerfectGroup`
Basic test of creating new groups (reading files in) Removed constructing all perfect groups, as this will be longer now Remove now pointless tests that checked for the discrepancy between claimed list (up to 10^6) and existing data.
Two perfect groups of orders 243000, and one each of order 729000, 871200 and 878460. They are clearly new by number of conjugacy classes and minimal failthful permdegrees.
Great job! That's definitely going to be a top tier in the release notes for 4.12 ;-) |
- gap-system#3925 belongs to 4.12.0 not 4.11.1, - gap-system#4053 now belongs to `topic: julia`, not to `kind: bug: crash` - removed a superfluous "in"
- gap-system#3925 belongs to 4.12.0 not 4.11.1, - gap-system#4053 now belongs to `topic: julia`, not to `kind: bug: crash` - removed a superfluous "in"
Added perfect groups of orders that had been missing in the Holt/Plesken book (newly computed). This increases the number of groups in the perfect groups library by a factor close to 6.
Also added 5 groups that were found missing in the existing lists.