Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: add CONST_BAG_HEADER #3884

Merged
merged 1 commit into from
Feb 7, 2020
Merged

kernel: add CONST_BAG_HEADER #3884

merged 1 commit into from
Feb 7, 2020

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin fingolfin added topic: kernel release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Feb 5, 2020
@fingolfin fingolfin mentioned this pull request Feb 5, 2020
Open
@coveralls
Copy link

coveralls commented Feb 5, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 84.766% when pulling 208dafc on fingolfin:mh/BAG_HEADER into a2326e4 on gap-system:master.

rbehrends
rbehrends approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@rbehrends rbehrends left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. However, as mentioned on the HPC-GAP PR, I'm not sure that we should use guard checks in the bag header functions; the change still serves code clarity and prevents accidental changes of header fields.

@fingolfin fingolfin merged commit bd6ec09 into gap-system:master Feb 7, 2020
@fingolfin fingolfin deleted the mh/BAG_HEADER branch February 9, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbehrends rbehrends rbehrends approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

Assignees
No one assigned
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fingolfin @coveralls @rbehrends