Fix bug NullspaceModQ that could lead to wrong results; also added support for arbitrary moduli, and renamed it to NullspaceModN
#3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gap-system#3614 and adds a manual example demonstrating the fixed behavior. The old name NullspaceModQ is kept as an alias for backwards compatibility. Also updated the documentation for NullspaceModN and BasisNullspaceModN.
fingolfin
added
kind: bug
hulpke
approved these changes
Oct 10, 2019
|
Backported to stable-4.11 in a1e58ee |
fingolfin
changed the title
NullspaceModQ that could lead to wrong results, added support for arbitrary moduli, and renamed it to NullspaceModN
fingolfin
added
the
kind: enhancement
fingolfin
changed the title
NullspaceModQ that could lead to wrong results, added support for arbitrary moduli, and renamed it to NullspaceModNNullspaceModQ that could lead to wrong results; also added support for arbitrary moduli, and renamed it to NullspaceModN
fingolfin
changed the title
NullspaceModQ that could lead to wrong results; also added support for arbitrary moduli, and renamed it to NullspaceModNNullspaceModQ that could lead to wrong results; also added support for arbitrary moduli, and renamed it to NullspaceModN
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3614 and adds a manual example demonstrating the fixed behavior.
The old name NullspaceModQ is kept as an alias for backwards compatibility.
Also updated the documentation for NullspaceModN and BasisNullspaceModN.
Should be OK to backport to stable-4.11