Clarify and correct documentation of CompositionMapping, add an example
#3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssiccha
added
kind: bug
fingolfin
requested changes
May 14, 2019
Clarifies the order in which the arguments are composed. Adds an example.
ssiccha
force-pushed
the
ss/fix-CompositionMapping
branch
from
ebfdd80
to
6049562
Compare
Codecov Report
@@ Coverage Diff @@
## master #3449 +/- ##
==========================================
+ Coverage 85.33% 85.34% +<.01%
==========================================
Files 699 699
Lines 346465 346465
==========================================
+ Hits 295673 295675 +2
+ Misses 50792 50790 -2
|
fingolfin
changed the title
CompositionMapping, add an example
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the order in which the arguments of CompositionMapping are composed.
Adds an example.