Remove '-a', other small input cleanups #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
added
kind: enhancement
fingolfin
requested changes
May 9, 2019
ChrisJefferson
force-pushed
the
cleanup-input
branch
from
4a3a1f2
to
ed827ea
Compare
Codecov Report
@@ Coverage Diff @@
## master #3444 +/- ##
==========================================
+ Coverage 85.34% 85.34% +<.01%
==========================================
Files 699 699
Lines 346092 346082 -10
==========================================
- Hits 295374 295367 -7
+ Misses 50718 50715 -3
|
fingolfin
approved these changes
May 9, 2019
The list of flags which are boolean is out of date, and a full list is now very long (as it includes some options with only long name versions)
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This performs some small cleanups to GAP's command line arguments. The main visible difference is removing
-a, which didn't actually do anything useful on modern OSes (it allocated, then freed, a bunch of memory).For release notes: