Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require SSortedLists to be homogeneous #3401

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Do not require SSortedLists to be homogeneous #3401

merged 1 commit into from
Apr 11, 2019

Conversation

ChrisJefferson
Copy link
Contributor

Fixes #3398

Basically, we were requiring SSortedLists be homogeneous. There was (I think) a point where that was true, but it's not a requirement any more.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.0e-05%) to 85.209% when pulling 311843d on ChrisJefferson:ssorted into bd34ff4 on gap-system:master.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them topic: kernel labels Apr 11, 2019
@ChrisJefferson ChrisJefferson mentioned this pull request Apr 11, 2019
Closed
ThomasBreuer
ThomasBreuer approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks o.k.

@fingolfin fingolfin merged commit 54f718c into gap-system:master Apr 11, 2019
@PaulaHaehndel PaulaHaehndel added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Apr 15, 2019
@fingolfin fingolfin changed the title Do not require SSortedLists are homogeneous Do not require SSortedLists to be homogeneous May 2, 2019
@ChrisJefferson ChrisJefferson deleted the ssorted branch May 8, 2019 16:53
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 21, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

Assignees
No one assigned
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

problem with strictly sorted inhomogeneous lists
7 participants
@ChrisJefferson @coveralls @fingolfin @ThomasBreuer @olexandr-konovalov @DominikBernhardt @PaulaHaehndel