Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow floating point values in memory command line options #3399

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

ChrisJefferson
Copy link
Contributor

So, I always assumed that -o 2.5G did what I expected (allocated 2.5GB of memory), but turns out the .5 was silently ignored. Switch to using atof so we parse a floating point number.

We still silently ignore badly written constants, but I think this is a useful improvement.

Release notes suggestion:

  • Support floating point numbers when specifying how much memory GAP should use, for example "-o 2.5G".

@ChrisJefferson ChrisJefferson added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Apr 10, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 85.195% when pulling d57645b on ChrisJefferson:mem-float into 7ea1f43 on gap-system:master.

@fingolfin
Copy link
Member

Should we also document this?

@ChrisJefferson
Copy link
Contributor Author

I felt this was already "documented", in that the docs don't say you can't give a floating point number, and personally I've been writing things like -o 2.5G for ages, not realising the .5 it wasn't doing anything useful.

@fingolfin fingolfin merged commit a0f3eed into gap-system:master Apr 11, 2019
@ChrisJefferson ChrisJefferson deleted the mem-float branch May 8, 2019 16:53
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 21, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants