Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgap: fix name of GAP_EnterDebugMessage_ #3325

Merged
merged 1 commit into from
Mar 6, 2019
Merged

libgap: fix name of GAP_EnterDebugMessage_ #3325

merged 1 commit into from
Mar 6, 2019

Conversation

fingolfin
Copy link
Member

Without this, GAP_ENTER_DEBUG is broken.

Note sure if we plan to make a GAP 4.10.2 before GAP 4.11, but just in case we might want to backport this to stable-4.10.

@fingolfin
libgap: fix name of GAP_EnterDebugMessage_
bf24ecd 
Without this, GAP_ENTER_DEBUG is broken
@fingolfin
Copy link
Member Author

Also: ping @embray

@dimpase
Copy link
Member

dimpase commented Mar 4, 2019

Sage's libgap interface in Sage's 8.7.beta* is not using the affected function.

@embray
Copy link
Contributor

embray commented Mar 4, 2019

Thanks; I remember running into this at some point too but just assuming I had already fixed it elsewhere.

@dimpase Technically it is if libgap is compiled with some debug flags enabled, but it's not used normally.

@dimpase
Copy link
Member

dimpase commented Mar 4, 2019

@embray I meant to say Sage does not use it directly, neither in the interface nor in patches.

@embray
Copy link
Contributor

embray commented Mar 4, 2019

It's never used directly. It's only used if GAP_ENTER_DEBUG is defined non-zero:

gap/src/libgap-api.h

Line 26 in bf24ecd

#ifndef GAP_ENTER_DEBUG

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 85.074% when pulling bf24ecd on fingolfin:mh/GAP_EnterDebugMessage into 843bc10 on gap-system:master.

@fingolfin
Copy link
Member Author

@dimpase well, if you might still approve this PR (Erik agrees that it is right), then we can merge it... :)

dimpase
dimpase approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fingolfin fingolfin merged commit 67050de into gap-system:master Mar 6, 2019
@fingolfin fingolfin deleted the mh/GAP_EnterDebugMessage branch March 6, 2019 06:55
@fingolfin fingolfin added release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Apr 15, 2019
@fingolfin fingolfin mentioned this pull request Jun 4, 2019
Merged
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.10.2 milestone Jun 12, 2019
@fingolfin fingolfin modified the milestone: GAP 4.10.2 Jun 13, 2019
@olexandr-konovalov
Copy link
Member

This is mentioned in release notes for GAP 4.11.0 but seems to be included in GAP 4.10.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

@markuspf markuspf Awaiting requested review from markuspf

Assignees
No one assigned
Labels
backport-to-4.10-DONE release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel topic: libgap things related to libgap
Projects
None yet
Milestone
GAP 4.10.2
Development

Successfully merging this pull request may close these issues.
5 participants
@fingolfin @dimpase @embray @coveralls @olexandr-konovalov