Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Scaling of gcd of polynomials to be standard #3227

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Jan 23, 2019

This fixes #3212

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them labels Jan 23, 2019
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the same change must also be applied to hpcgap/lib/polyrat.gi. Could you please do that? Alternatively, I can amend your PR accordingly for you tomorrow.

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #3227 into master will decrease coverage by 0.03%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master    #3227      +/-   ##
==========================================
- Coverage    84.8%   84.77%   -0.04%     
==========================================
  Files         688      689       +1     
  Lines      331047   336349    +5302     
==========================================
+ Hits       280754   285133    +4379     
- Misses      50293    51216     +923
Impacted Files Coverage Δ
lib/polyrat.gi 78.14% <33.33%> (-0.16%) ⬇️
hpcgap/lib/polyrat.gi 70.83% <42.85%> (-0.14%) ⬇️
src/vector.c 92.73% <0%> (-5.01%) ⬇️
src/hookintrprtr.c 67.34% <0%> (-4.88%) ⬇️
src/iostream.c 62.35% <0%> (-4.31%) ⬇️
src/lists.c 76.55% <0%> (-4.06%) ⬇️
src/vecffe.c 71.02% <0%> (-3.42%) ⬇️
src/c_type1.c 86.47% <0%> (-2.98%) ⬇️
src/vecgf2.c 73.3% <0%> (-2.56%) ⬇️
src/system.c 73.54% <0%> (-2.33%) ⬇️
... and 82 more

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 84.646% when pulling 4210bab on hulpke:fixes into f27cff4 on gap-system:master.

@fingolfin
Copy link
Member

Backported to stable-4.10 in commit 9a6034d

@olexandr-konovalov olexandr-konovalov added this to the GAP 4.10.1 milestone Jan 26, 2019
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Feb 23, 2019
@fingolfin fingolfin removed this from the GAP 4.10.1 milestone Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-4.10-DONE kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gcd no longer returns standard associates?
4 participants