-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Scaling of gcd of polynomials to be standard #3227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the same change must also be applied to hpcgap/lib/polyrat.gi
. Could you please do that? Alternatively, I can amend your PR accordingly for you tomorrow.
Codecov Report
@@ Coverage Diff @@
## master #3227 +/- ##
==========================================
- Coverage 84.8% 84.77% -0.04%
==========================================
Files 688 689 +1
Lines 331047 336349 +5302
==========================================
+ Hits 280754 285133 +4379
- Misses 50293 51216 +923
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Backported to stable-4.10 in commit 9a6034d |
This fixes #3212