Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx overlapping memcpy in APPEND_LIST #3216

Merged

Conversation

ChrisJefferson
Copy link
Contributor

I found this while trying to figure out why XModAlg crashes in startup sometimes.

I don't think this can be the problem... but it technically an error, which is triggered when loading XModAlg.

src/listfunc.c Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.643% when pulling 9f7130a on ChrisJefferson:fix-memcpy-appendlist into 9d485d6 on gap-system:master.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them topic: kernel backport-to-4.10 labels Jan 22, 2019
@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #3216 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3216   +/-   ##
=======================================
  Coverage   84.76%   84.76%           
=======================================
  Files         687      687           
  Lines      335864   335864           
=======================================
  Hits       284690   284690           
  Misses      51174    51174
Impacted Files Coverage Δ
src/listfunc.c 93.33% <100%> (ø) ⬆️

@ChrisJefferson ChrisJefferson merged commit 7669c81 into gap-system:master Jan 22, 2019
@fingolfin
Copy link
Member

Backported to stable-4.10 in 67e51c0

@olexandr-konovalov olexandr-konovalov added this to the GAP 4.10.1 milestone Feb 23, 2019
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Feb 23, 2019
@ChrisJefferson ChrisJefferson deleted the fix-memcpy-appendlist branch February 27, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-4.10-DONE kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants