Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable-4.10: backport two buildsys changes to the GAPARCH #3182

Merged

Conversation

fingolfin
Copy link
Member

This PR backports two commits from master that change the GAPARCH string:

These changes are useful when one wants to debug HPC-GAP and Julia builds of GAP together with packages, as the different GAPARCHs ensure that rebuilding the same package for each build variant leaves separate binaries, so the package then can be used by those different builds (i.e., no need to keep separate pkg dirs, one can use out-of-tree builds for the different build configs).

The main concern (and the reason I did not push these backports directly) is that perhaps some code somewhere could be broken by the modified GAPARCH... We already tried hard to ensure that all deposited packages keep working, and I can't really think of problems, but I want that (a) tests for this change are run, and (b) would like to know if e.g. @ChrisJefferson can think of any potential issues

ChrisJefferson and others added 2 commits January 16, 2019 15:41
This allow the version to be used in the ABI and allow it to be
more easily accessed by packages without parsing headers
@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #3182 into stable-4.10 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           stable-4.10    #3182   +/-   ##
============================================
  Coverage        75.89%   75.89%           
============================================
  Files              482      482           
  Lines           240171   240171           
============================================
  Hits            182280   182280           
  Misses           57891    57891
Impacted Files Coverage Δ
src/modules.h 100% <ø> (ø) ⬆️

@olexandr-konovalov
Copy link
Member

I started a test of this PR on Jenkins - hopefully will finish tomorrow.

@ChrisJefferson
Copy link
Contributor

This looks ok to me

Copy link
Member

@olexandr-konovalov olexandr-konovalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins tests pass too.

@olexandr-konovalov olexandr-konovalov merged commit 16e8613 into gap-system:stable-4.10 Jan 18, 2019
@fingolfin fingolfin deleted the mh/stable-4.10-GAPARCH branch January 18, 2019 11:15
@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants