Allow input and output to be mixed in Test #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
force-pushed
the
test-fix
branch
from
38f1b07
to
85eb95f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
+ Coverage 83.68% 83.68% +<.01%
==========================================
Files 688 688
Lines 336637 336633 -4
==========================================
- Hits 281724 281721 -3
+ Misses 54913 54912 -1
|
fingolfin
reviewed
Jan 10, 2019
tst/testinstall/interpreter.tst
Outdated
| @@ -248,6 +248,25 @@ gap> Unbind(l![fail]); | |||
| Error, PosObj Assignment: <position> must be a positive small integer (not the\ | |||
| value 'fail') | |||
|
|
|||
| # | |||
| # Statements where input + output are mixed | |||
| # Checks test can handle output directly cute+pasted from GAP's output | |||
There was a problem hiding this comment.
Suggested change
| # Checks test can handle output directly cute+pasted from GAP's output | |
| # Checks test can handle output directly cut+pasted from GAP's output |
There was a problem hiding this comment.
Also, why is this in interpreter.c? It's a test for Test, not the interpreter, isn't it? Note that interpreter.tst is meant to be in sync with coder.tst -- we already violate this right now (my fault) but I was recently working on fixing this again, and would prefer not to drift more.
That said, I'll survive if we add it here, I'll just move it elsewhere when I get to finish that sync I just mentioned.
This was previously forbidden as it can lead to confusing errors, but it also broke some valid Tests, as GAP can begin outputting before a complete statement has been inputted.
ChrisJefferson
force-pushed
the
test-fix
branch
from
85eb95f
to
32f0a71
Compare
fingolfin
approved these changes
Jan 10, 2019
wilfwilson
added
the
release notes: to be added
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously forbidden as it can lead to confusing errors,
but it also broke some valid Tests, as GAP can begin outputting
before a complete statement has been inputted.
In particular, this previous change broke the "Browse" package.