-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend the default BrauerTableOp
method
#3129
extend the default BrauerTableOp
method
#3129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (failed tests caused by the problem with Julia that should be fixed by #3131). You may wish to rebase it to have a clean pass, and look at two suggestions.
I was also wondering if GAP should have a PPart
function. It has PValuation
, but will it be better to use p^PValuation(n,p)
instead of the loop that you use to calculate the ppart
- I am not sure.
n:= n / p; | ||
od; | ||
if ppart in OrdersClassRepresentatives( tbl ) then | ||
# The Sylow 'p'-subgroup is cyclic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to remove quotes around p
to ease reading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasBreuer just to explain why: I read that first as p'-subgroup
, then reread to figure out what does that mean. The style you use here is not consistent with other styles used in the GAP library: for example we have
grp.gi: # compute generators for the torsion Omega p-subgroups of the center
grpprmcs.gi:## O_p(G), the p-core of G, is the maximal normal p-subgroup
grpprmcs.gi: # abelian normal p-subgroup of G
grpprmcs.gi: # p-subgroup of G; taking commutator subgroups, find abelian normal
grpprmcs.gi: # p-subgroup of G.
grpprmcs.gi: # p-subgroup; kernel is abelian p-group. Take image at this action, and
and also one case of
ctblsolv.gi: # Choose a normal elementary abelian `p'-subgroup `N',
- extended the default `BrauerTableOp` method to the case of cyclic defect such that all Brauer characters lift to characteristic zero (this case can be detected from the ordinary character table) - extended the documentation accordingly - extended the tests accordingly
6c9d2c5
to
cb36c5c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3129 +/- ##
==========================================
+ Coverage 83.58% 83.59% +<.01%
==========================================
Files 687 687
Lines 336919 336957 +38
==========================================
+ Hits 281619 281671 +52
+ Misses 55300 55286 -14
|
extended the default
BrauerTableOp
method to the caseof cyclic defect such that all Brauer characters lift
to characteristic zero (this case can be detected from the
ordinary character table)
extended the documentation accordingly
extended the tests accordingly