Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENHANCE: Special redispatch for Nat.Hom.ByNS if group is found out to be finite #3075

Merged
merged 1 commit into from
Dec 2, 2018
Merged

ENHANCE: Special redispatch for Nat.Hom.ByNS if group is found out to be finite #3075

merged 1 commit into from
Dec 2, 2018

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Dec 1, 2018

This is needed, as for matrix groups the earlier NiceMonomorphism dispatch does not hold.
Test is only done before expesive action search is started, so negligible cost.

Also added redispatches in case the NiceMonomorphism approach is ever removed.

This fixes #3070

@hulpke
ENHANCE: Special redispatch for Nat.Hom.ByNS if group is found out to…
c17aca1 
… be finite

This is needed, as for matrix groups the earlier `NiceMonomorphism` dispatch does not hold.
Test is only done before expesive action search is started, so negligible cost.

Also added redispatches in case the NiceMonomorphism approach is ever removed.

This fixes gap-system#3070

Added testfile
markuspf
markuspf approved these changes Dec 1, 2018
View reviewed changes
Copy link
Member

@markuspf markuspf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I rummaged around to see how GAP proves the finiteness of the matrix group, and I wasnt' aware that this functionality exists.

@ChrisJefferson ChrisJefferson merged commit 8b1ff24 into gap-system:master Dec 2, 2018
@wilfwilson wilfwilson added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label Apr 15, 2019
@markusbaumeister markusbaumeister added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Apr 16, 2019
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 22, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@markuspf markuspf markuspf approved these changes

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

g/c for (matrix) groups only works after Order(g) is called
7 participants
@hulpke @ChrisJefferson @markuspf @olexandr-konovalov @DominikBernhardt @wilfwilson @markusbaumeister