(FL) Fix readline crash when using autocomplete with colored-completion-prefix turned on in Bash
#2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reported including a first proposed fix by @ChrisJefferson ("Fix readline crash" gap-system#2986 in github.) With this patch the ~/.inputrc setting set colored-completion-prefix on should be supported correctly (by giving the word to be completed to readline's display function).
Make sure that rl_readline_name = "GAP" is set before the rl_initialize(); initialization of readline. Otherwise GAP specific settings in ~/.inputrc under $if GAP ... $endif are not read at startup.
|
Thanks, this is much better than my PR. |
ChrisJefferson
approved these changes
Nov 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #2991 +/- ##
==========================================
- Coverage 85.21% 85.21% -0.01%
==========================================
Files 110 110
Lines 56857 56859 +2
==========================================
+ Hits 48450 48451 +1
- Misses 8407 8408 +1
|
markuspf
added
kind: bug: crash
olexandr-konovalov
added
release notes: added
olexandr-konovalov
changed the title
colored-completion-prefix turned on in Bash
fingolfin
added
the
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative for the pull request "Fix readline crash" #2986 by @ChrisJefferson.
@ChrisJefferson: Thanks for the report! I very rarely had crashes from completions before (also without the 'colored-completion-prefix' switch of readline, but could never reproduce them.
I agree that your proposed fix (#2986) should avoid the crashes, but as you already mentioned, the 'colored-completion-prefix' switch does not yet work. This should be fixed by the present patch.
A second commit also fixes the problem that GAP did not read a '$if GAP' section of '~/.inputrc' on startup.