Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix task scanning for the Julia GC #2969

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Fix task scanning for the Julia GC #2969

merged 1 commit into from
Nov 12, 2018

Conversation

rbehrends
Copy link
Contributor

This is a tracking issue to discuss and track changes for scanning Julia task stacks.

@rbehrends rbehrends added do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) kind: discussion discussions, questions, requests for comments, and so on do not review PRs which are not yet ready for a proper external review (e.g. only submitted for test results) labels Nov 7, 2018
fingolfin
fingolfin reviewed Nov 7, 2018
View reviewed changes
src/julia_gc.c Show resolved Hide resolved
src/julia_gc.c Outdated Show resolved Hide resolved
src/julia_gc.c Outdated Show resolved Hide resolved
src/julia_gc.c Outdated Show resolved Hide resolved
src/julia_gc.c Outdated Show resolved Hide resolved
src/julia_gc.c Outdated Show resolved Hide resolved
src/julia_gc.c Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 8, 2018 •
edited
Loading

Codecov Report

Merging #2969 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
- Coverage   83.86%   83.85%   -0.01%     
==========================================
  Files         681      679       -2     
  Lines      341774   341540     -234     
==========================================
- Hits       286637   286412     -225     
+ Misses      55137    55128       -9
Impacted Files Coverage Δ
src/iostream.c 66.39% <0%> (-1.22%) ⬇️
src/system.c 70.98% <0%> (-0.87%) ⬇️
lib/init.g 80.06% <0%> (-0.7%) ⬇️
src/gap.c 83.8% <0%> (-0.34%) ⬇️
lib/csetgrp.gi 71.72% <0%> (-0.28%) ⬇️
src/ariths.c 99.76% <0%> (-0.24%) ⬇️
src/blister.c 98.38% <0%> (-0.16%) ⬇️
src/integer.c 98.09% <0%> (-0.1%) ⬇️
src/hpc/aobjects.c 69.83% <0%> (-0.08%) ⬇️
src/hpc/threadapi.c 45.25% <0%> (-0.04%) ⬇️
... and 30 more

fingolfin
fingolfin reviewed Nov 8, 2018
View reviewed changes
src/julia_gc.c Outdated Show resolved Hide resolved
fingolfin
fingolfin reviewed Nov 8, 2018
View reviewed changes
src/julia_gc.c Outdated Show resolved Hide resolved
@rbehrends rbehrends force-pushed the gc-taskscan branch 2 times, most recently from 6d8833e to 5dacca3 Compare November 9, 2018 13:52
@fingolfin fingolfin added topic: kernel release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes backport-to-4.10 and removed do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) do not review PRs which are not yet ready for a proper external review (e.g. only submitted for test results) kind: discussion discussions, questions, requests for comments, and so on labels Nov 9, 2018
@fingolfin fingolfin changed the title WIP: Fix task scanning for the Julia GC Fix task scanning for the Julia GC Nov 9, 2018
fingolfin
fingolfin approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@fingolfin
Copy link
Member

This is a bit unusual, but I'd like to backport this PR to stable-4.10, for inclusion in GAP 4.10.1. The rationale being that (a) this code is not executed by any regular user, (b) it means that people will be able to use a stock GAP 4.10.1 with our ongoing GAP-Julia integration work, instead of having to wait for GAP 4.11 for that.

Any objections to that plan? @ChrisJefferson @markuspf @alex-konovalov everybody?

@fingolfin fingolfin merged commit e0efc8a into gap-system:master Nov 12, 2018
@fingolfin fingolfin mentioned this pull request Nov 13, 2018
Closed
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.10.1 milestone Nov 24, 2018
@olexandr-konovalov
Copy link
Member

Backported in b0ee110

@olexandr-konovalov olexandr-konovalov added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 23, 2019
@fingolfin fingolfin mentioned this pull request May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
backport-to-4.10-DONE release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Milestone
GAP 4.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rbehrends @fingolfin @olexandr-konovalov