Replace all calls to SetFeatureObj, mark it as obsolete #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: library
release notes: to be added
Various packages still use it, and most likely also code that people keep around locally, so we cannot and should not remove it for the foreseeable future. But at least new code should not use it.
fingolfin
force-pushed
the
mh/SetFeatureObj
branch
from
7c5237c
to
ba731a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2919 +/- ##
==========================================
+ Coverage 82.82% 83.76% +0.94%
==========================================
Files 678 681 +3
Lines 342034 346596 +4562
==========================================
+ Hits 283275 290332 +7057
+ Misses 58759 56264 -2495
|
|
This is a rather trivial PR, it would be great if somebody could review it... |
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various packages still use it, and most likely also code that people keep
around locally, so we cannot and should not remove it for the foreseeable
future. But at least new code should not use it.