Fix ShallowCopy for IteratorOfCartesianProduct #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
fingolfin
commented
Sep 19, 2018
configure.ac
Outdated
| [boehm], [AS_IF([test "x$enable_hpcgap" = xno], | ||
| [AC_MSG_ERROR([Boehm GC can only be used with HPC-GAP])]) | ||
| AC_SUBST([GC_SOURCES], [src/boehm_gc.c]) | ||
| [boehm], [AC_SUBST([GC_SOURCES], [src/boehm_gc.c]) |
There was a problem hiding this comment.
Ouch, this was not meant to be here, I'll remove it ASAP
fingolfin
force-pushed
the
mh/fix-IteratorOfCartesianProduct
branch
from
1fc1605
to
b80da18
Compare
Codecov Report
@@ Coverage Diff @@
## master #2829 +/- ##
==========================================
+ Coverage 76.05% 76.07% +0.01%
==========================================
Files 480 480
Lines 241022 241022
==========================================
+ Hits 183310 183352 +42
+ Misses 57712 57670 -42
|
olexandr-konovalov
approved these changes
Sep 19, 2018
There was a problem hiding this comment.
Looks good, thanks. There was also another fix in IteratorOfCartesianProduct recently #2420
mohamed-barakat
approved these changes
Sep 19, 2018
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @mohamed-barakat
Could be backported to 4.10 (but feel free to disagree, and remove the backport label again).