Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: unify 'and' for filters in interpreter and executor #2755

Closed
wants to merge 2 commits into from
Closed

kernel: unify 'and' for filters in interpreter and executor #2755

wants to merge 2 commits into from

Commits on Sep 12, 2018

  1. kernel: add Warning() helper

    @fingolfin
    fingolfin committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    2e6772e View commit details
    Browse the repository at this point in the history

  2. kernel: unify 'and' for filters in interpreter and executor 

    Also start using IS_FILTER. Note that previously, this input was silently accepted:

  gap> Center and IsAssociative;
  <Filter "<<and-filter>>">

This was effectively treated equivalently to `HasCenter and IsAssociative;`.
We now could reject such code. But unfortunately a few packages accidentally
relied on this bug. We thus only print a warning for now, and will turn this
into a proper error only once all affect packages released a fixed version.
    @fingolfin
    fingolfin committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    54c34b7 View commit details
    Browse the repository at this point in the history