Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: fix LogFFE to not return negative results on 32 bit systems #2689

Merged
merged 1 commit into from
Aug 11, 2018
Merged

kernel: fix LogFFE to not return negative results on 32 bit systems #2689

merged 1 commit into from
Aug 11, 2018

Conversation

fingolfin
Copy link
Member

Fixes #2687

While looking at the FFE code, I noticed more issues, but I'll submit fixes for those separately.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: kernel release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 9, 2018
@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #2689 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
+ Coverage   75.41%   75.41%   +<.01%     
==========================================
  Files         478      478              
  Lines      241598   241598              
==========================================
+ Hits       182205   182211       +6     
+ Misses      59393    59387       -6
Impacted Files Coverage Δ
src/finfield.c 91.44% <100%> (+0.34%) ⬆️
hpcgap/lib/hpc/stdtasks.g 64.45% <0%> (+1.02%) ⬆️

@fingolfin fingolfin mentioned this pull request Aug 9, 2018
Merged
@fingolfin fingolfin merged commit cbcab8e into gap-system:master Aug 11, 2018
@fingolfin fingolfin deleted the mh/fix-LogFFE branch August 11, 2018 13:43
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.10.0 milestone Sep 2, 2018
@fingolfin fingolfin changed the title kernel: fix LogFFE on 32 bit systems kernel: fix LogFFE to not return negative results on 32 bit systems Sep 21, 2018
@fingolfin fingolfin added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuspf markuspf markuspf approved these changes

Assignees
No one assigned
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Milestone
GAP 4.10.0
Development

Successfully merging this pull request may close these issues.

LogFFE returns negative results on 32 bit
3 participants
@fingolfin @markuspf @olexandr-konovalov