Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove unused CheckAuto() #2670

Merged
merged 1 commit into from
Aug 11, 2018

Conversation

fingolfin
Copy link
Member

This is neither used by the library nor by any packages

This is neither used by the library nor by any packages
@fingolfin fingolfin added topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jul 30, 2018
@stevelinton
Copy link
Contributor

Looks like a debugging tools that somebody needed once. Unlike many such, it's fairly clear what it does, and it doesn't look like it's suffered bitrot (yet). On the other hand anyone who's likely to be able to use it effectively can probably rewrite it in two minutes. Is it better to document and retain such things (maybe in a separate directory), or to delete them?

@fingolfin fingolfin requested a review from hulpke August 10, 2018 13:44
@fingolfin
Copy link
Member Author

Well, that function was originally added by Bettina 1997-07-07; it was updated later by e.g. @hulpke

Instead of removing this, one could of course also add test cases using it, and or Assert statements to relevant functions. Perhaps @hulpke has a preference on this?

Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was a test function (predating me understanding the concept of assertions) that was there to catch obvious errors.
Its not needed any more.

@fingolfin fingolfin merged commit a82d57e into gap-system:master Aug 11, 2018
@fingolfin fingolfin deleted the mh/remove-CheckAuto branch August 11, 2018 20:12
@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants