Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xgap redirection of errout #2660

Merged
merged 1 commit into from
Jul 28, 2018
Merged

Fix xgap redirection of errout #2660

merged 1 commit into from
Jul 28, 2018

Conversation

ChrisJefferson
Copy link
Contributor

This fixes xgap's special redirection of errout. Without this, xgap (and gap.app, which uses the same interface) don't correctly display break loops.

@codecov
Copy link

codecov bot commented Jul 26, 2018 •
edited
Loading

Codecov Report

Merging #2660 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2660      +/-   ##
==========================================
+ Coverage   75.19%   75.19%   +<.01%     
==========================================
  Files         478      478              
  Lines      242242   242243       +1     
==========================================
+ Hits       182144   182146       +2     
+ Misses      60098    60097       -1
Impacted Files Coverage Δ
src/system.c 72.14% <0%> (-0.21%) ⬇️
src/iostream.c 62.35% <0%> (-1.15%) ⬇️
hpcgap/lib/hpc/stdtasks.g 64.96% <0%> (+1.27%) ⬆️

@ChrisJefferson ChrisJefferson added kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them topic: kernel release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jul 26, 2018
@markuspf markuspf merged commit 4ea4f4a into gap-system:master Jul 28, 2018
@fingolfin fingolfin added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jul 31, 2018
@ChrisJefferson ChrisJefferson deleted the fix-xgap branch August 20, 2018 10:05
@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisJefferson @fingolfin @markuspf