Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround crash in issue #2487 in GAP 4.9 #2596

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Workaround crash in issue #2487 in GAP 4.9 #2596

merged 1 commit into from
Jul 3, 2018

Conversation

fingolfin
Copy link
Member

This imitates a change already in the master branch.

@fingolfin
Workaround crash in issue gap-system#2487 in GAP 4.9
d10ea90 
This imitates a change already in the master branch.
@fingolfin fingolfin added this to the GAP 4.9.2 milestone Jul 2, 2018
markuspf
markuspf approved these changes Jul 2, 2018
View reviewed changes
Copy link
Member

@markuspf markuspf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack: Ok to fix a user-facing crash, even if it does not fix the underlying issue.

The underlying issue is described in #2487, so we hopefully won't forget (even if "everything works fine" now).

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) topic: kernel labels Jul 2, 2018
@olexandr-konovalov olexandr-konovalov mentioned this pull request Jul 2, 2018
Merged
olexandr-konovalov
olexandr-konovalov approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@olexandr-konovalov olexandr-konovalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - @fingolfin confirms that he tested that this fixes the crash, and https://codecov.io/gh/gap-system/gap/pull/2596/diff reports that the diff is covered by tests.

@olexandr-konovalov olexandr-konovalov merged commit c9f2b58 into gap-system:stable-4.9 Jul 3, 2018
@olexandr-konovalov olexandr-konovalov mentioned this pull request Jul 3, 2018
Closed
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jul 3, 2018
@fingolfin fingolfin deleted the mh/workaround-2487 branch October 28, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuspf markuspf markuspf approved these changes

@olexandr-konovalov olexandr-konovalov olexandr-konovalov approved these changes

Assignees
No one assigned
Labels
kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Milestone
GAP 4.9.2
Development

Successfully merging this pull request may close these issues.
3 participants
@fingolfin @markuspf @olexandr-konovalov