Add forms for Omega(e,d,q), except when d odd, q even; some cleanup #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: enhancement
fingolfin
force-pushed
the
mh/Omega-forms
branch
from
15110f3
to
8fe7f65
Compare
Codecov Report
@@ Coverage Diff @@
## master #2577 +/- ##
==========================================
- Coverage 74.6% 74.6% -0.01%
==========================================
Files 481 481
Lines 242383 242354 -29
==========================================
- Hits 180837 180812 -25
+ Misses 61546 61542 -4
|
ChrisJefferson
approved these changes
Jun 28, 2018
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a new helper
SetInvariantQuadraticFormFromMatrixwhich reduces some code duplication and as a side effect enforces the invariantB = Q + Q^tr, where B is the Gram matrix of the invariant bilinear form of an orthogonal group G, and Q is the Gram matrix of its invariant quadratic form.The reason for excluding the case where d is odd, q is even, is described in issue #2576