Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two bugs related to empty magmas #2452

Merged
merged 1 commit into from
May 18, 2018
Merged

Fix two bugs related to empty magmas #2452

merged 1 commit into from
May 18, 2018

Commits on May 16, 2018

  1. Fix two bugs related to empty magmas 

    First, SubadditiveMagma(a,[]) computes an empty magma, but we erroneously set
IsTrivial for it, which implies size 1. This was changed to IsEmpty.

Secondly, there was an implication from "IsFiniteOrderElementCollection and
IsMagma" to IsMagmaWithInverses. But such a collection may be empty, hence the
implication is invalid as given.

Fixes gap-system#2400
    @fingolfin
    fingolfin committed May 16, 2018
    Configuration menu
    Copy the full SHA
    6f56213 View commit details
    Browse the repository at this point in the history