Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from grpauto.tst a test which exceeds memory limits #2407

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

olexandr-konovalov
Copy link
Member

@olexandr-konovalov olexandr-konovalov commented Apr 25, 2018

This will allow to avoid test failure reported in #2377 in
stable-4.9 branch. The fix in the master branch will be done
differently. This test is duplicated in benchmarks, so we will
monitor its status there.

@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.1 milestone Apr 25, 2018
@olexandr-konovalov olexandr-konovalov added the topic: tests issues or PRs related to tests label Apr 25, 2018
This will allow to avoid test failure reported in gap-system#2377 in
stable-4.9 branch. The fix in the master branch will be done
differently. This test is duplicated in benchmarks, so we will
monitor its status there.
Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For stable this is fine. In master the problem will go away once #2383 is merged

@hulpke
Copy link
Contributor

hulpke commented Apr 25, 2018

Just curiosity: How did we decide on the 1G limit? These larger group theoretic calculations are testing a lot of different (and involved) functions on the way.

@olexandr-konovalov
Copy link
Member Author

@hulpke -o 1g was used in make test... targets for quite long time - I can't find a link to some discussion about possibly raising limits. IIRC last time we still decided to keep -o 1g which is lower than default. My argument in favour of 1g is that it helps to track memory regressions - like in this case, which would remain unnoticed in default settings.

Today, if you want to add a genuine test which demands more memory, I suggest to put it to benchmark, which allow to use different (also standardised) memory limits (this is the current setup, open for suggestions and improvements). Benchmarks are run weekly on Jenkins CI in St Andrews.

@fingolfin fingolfin merged commit f217bb6 into gap-system:stable-4.9 Apr 26, 2018
@fingolfin fingolfin deleted the fix-grpauto branch April 26, 2018 07:07
@olexandr-konovalov olexandr-konovalov added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: tests issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants