kernel: fix tracing of mutable variants of One/Zero/Inv/AInv; some cleanup #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
fingolfin
force-pushed
the
mh/cleanup-ariths
branch
from
a4c5ef5
to
731f148
Compare
Codecov Report
@@ Coverage Diff @@
## master #2365 +/- ##
==========================================
+ Coverage 73.22% 73.22% +<.01%
==========================================
Files 482 482
Lines 246392 246396 +4
==========================================
+ Hits 180415 180432 +17
+ Misses 65977 65964 -13
|
fingolfin
force-pushed
the
mh/cleanup-ariths
branch
from
731f148
to
732ff81
Compare
.. by replacing a duplicate InstallZeroObject call
This strange code calls EQ(intobj, prec). I think this used to (sometimes) work because in the past, there was code in GAP to allow precords to act like external objects; however, this code has been removed years ago (e.g. some of it by me in 2014).
... by changing ChangeDoOperations to invoke the right functions for each operation; and also deal with the mutable variants of One/Zero/Inv/AInv.
ChrisJefferson
approved these changes
Apr 16, 2018
fingolfin
added
the
release notes: to be added
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.