Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleGroup: some fixes; better input validation; tests #2326

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

fingolfin
Copy link
Member

  • adjust case of error messages
  • catch various invalid parameters classical groups, instead of
    returning non-simple groups with IsSimpleGroup forcibly set
  • fix error message for 2E(n,q) with n<>6 (referred to 3D with n<>4)
  • add tests

* adjust case of error messages
* catch various invalid parameters classical groups, instead of
  returning non-simple groups with IsSimpleGroup forcibly set
* fix error message for 2E(n,q) with n<>6 (referred to 3D with n<>4)
* add tests
@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: tests issues or PRs related to tests labels Mar 28, 2018
@fingolfin fingolfin requested a review from hulpke March 28, 2018 19:12
@codecov
Copy link

codecov bot commented Mar 28, 2018

Codecov Report

Merging #2326 into master will increase coverage by 0.05%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master    #2326      +/-   ##
==========================================
+ Coverage   72.52%   72.58%   +0.05%     
==========================================
  Files         478      478              
  Lines      246799   246812      +13     
==========================================
+ Hits       178996   179151     +155     
+ Misses      67803    67661     -142
Impacted Files Coverage Δ
grp/simple.gi 77.39% <96.15%> (+16.77%) ⬆️
src/hpc/traverse.c 95.75% <0%> (-0.59%) ⬇️
src/hpc/threadapi.c 37.22% <0%> (-0.2%) ⬇️
src/funcs.c 80.19% <0%> (-0.14%) ⬇️
src/gap.c 80.29% <0%> (-0.09%) ⬇️
src/objset.c 81.71% <0%> (+0.22%) ⬆️
lib/grp.gi 85.81% <0%> (+0.34%) ⬆️

Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have called it a bug, but yes, these are good additions.

@fingolfin
Copy link
Member Author

hmm, so what do you call groups of order 1, 6 or 18 labelled by GAP as simple groups? :-). They lead to all kinds of interesting interactions subsequently.

@fingolfin fingolfin merged commit f6a5560 into gap-system:master Mar 29, 2018
@fingolfin fingolfin deleted the mh/simplegroup branch March 29, 2018 06:57
@hulpke
Copy link
Contributor

hulpke commented Mar 29, 2018

They are not simple, of course. If the name corresponds to a simple group an isomorphic group is returned. Otherwise the result is undefined :-)

@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: tests issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants