Speed up IsPrimePowerInt in a few more cases, and fix a IsNilpotenGroup method #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
Codecov Report
@@ Coverage Diff @@
## master #2306 +/- ##
==========================================
+ Coverage 72.52% 72.52% +<.01%
==========================================
Files 478 478
Lines 246816 246824 +8
==========================================
+ Hits 179003 179013 +10
+ Misses 67813 67811 -2
|
Specifically, for large inputs with some relatively small divisors. This makes the performance of IsPrimePowerInt for numbers whose smallest prime divisors are beyond the `Primes` list degrade more smoothly. For powers of small primes (< 1000) the new code is never even triggered. Before: gap> IsPrimePowerInt(1009^1013 * 1013); time; false 274 After: gap> IsPrimePowerInt(1009^1013 * 1013); time; false 2
The trivial group is a p-group in GAP, but 1 is *not* a prime power.
fingolfin
force-pushed
the
mh/speedup-IsPrimePowerInt
branch
from
e185cb7
to
ad8fc40
Compare
ChrisJefferson
approved these changes
Apr 10, 2018
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the bug fix for the IsNilpotentGroup method normally is not necessary, because of immediate methods; but if immediate methods are turned off, the issue becomes apparent (already with our existing test suite, hence I am not adding a new tests for this).