Random source for additive cosets, grpnice and external orbits #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changing Random for Additive Cosets to use InstallWithRandomSource. - Adding tests for Random on Additive Cosets ino random.tst . - Adding a missing comma in coll.gi.
Adding InstallWithRandomSource for grpnice. All other changes had already been implemented, and suitable tests already existed.
|
Thanks, this looks great. I'll just wait for the tests to cycle. Thanks for poking at this fairly horrible area. Hopefully translating other random methods is going to get easier from here! |
ChrisJefferson
approved these changes
Mar 20, 2018
-Changing Random for external orbits to use install with random source. - Adding tests.
|
@ChrisJefferson thank you :) - it did end up being trickier than I had expected. |
grouptheoryenthusiast
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2272 +/- ##
==========================================
+ Coverage 70.86% 70.86% +<.01%
==========================================
Files 480 480
Lines 253246 253266 +20
==========================================
+ Hits 179455 179484 +29
+ Misses 73791 73782 -9
|
fingolfin
added
kind: enhancement
fingolfin
changed the title
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins to address some of the points raised in issue #1098 .
In particular we: