Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsCentral methods where second argument is an element #2185

Merged
merged 2 commits into from
Feb 21, 2018

Conversation

fingolfin
Copy link
Member

The documentation for IsCentral already claims these methods exist, but they never did. Add them in a systematic fashion.

Resolves #1795

@markuspf
Copy link
Member

We should probably add some tests for them as well.

@fingolfin
Copy link
Member Author

Yeah but I was too tired to add those now, too. I'll revisit this PR later (but in the meantime, didn't want to loose these changes in my stack)

@codecov
Copy link

codecov bot commented Feb 15, 2018

Codecov Report

Merging #2185 into master will increase coverage by <.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #2185      +/-   ##
==========================================
+ Coverage   69.72%   69.72%   +<.01%     
==========================================
  Files         482      482              
  Lines      254483   254483              
==========================================
+ Hits       177435   177443       +8     
+ Misses      77048    77040       -8
Impacted Files Coverage Δ
lib/ring.gi 51.93% <ø> (ø) ⬆️
lib/algebra.gi 72.45% <ø> (ø) ⬆️
lib/grp.gi 84.42% <ø> (-0.06%) ⬇️
lib/magma.gi 50.29% <ø> (ø) ⬆️
lib/magma.gd 79.31% <25%> (+17.4%) ⬆️
src/hpc/threadapi.c 36.9% <0%> (-0.1%) ⬇️
src/hpc/traverse.c 95.47% <0%> (+0.02%) ⬆️
src/opers.c 81.47% <0%> (+0.05%) ⬆️
src/stats.c 85.17% <0%> (+0.13%) ⬆️
hpcgap/lib/hpc/stdtasks.g 38.87% <0%> (+0.25%) ⬆️
... and 2 more

@fingolfin
Copy link
Member Author

I added some tests. Let's see how Travis and codecov like them.

Copy link
Member

@markuspf markuspf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Subject to the tests passing, etc..)

@markuspf markuspf merged commit a218d68 into gap-system:master Feb 21, 2018
@fingolfin fingolfin deleted the mh/IsCentral branch February 21, 2018 16:05
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants