Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one IsPNilpotent method, and add some tests #2106

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

fingolfin
Copy link
Member

Fixes #2099

@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Jan 23, 2018
@codecov
Copy link

codecov bot commented Jan 23, 2018

Codecov Report

Merging #2106 into master will decrease coverage by 12.07%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #2106       +/-   ##
===========================================
- Coverage   69.22%   57.15%   -12.08%     
===========================================
  Files         489      426       -63     
  Lines      256253   221359    -34894     
===========================================
- Hits       177395   126508    -50887     
- Misses      78858    94851    +15993
Impacted Files Coverage Δ
lib/grp.gi 71.9% <100%> (-12.56%) ⬇️
lib/attr.gi 0% <0%> (-100%) ⬇️
lib/teachm2.g 0% <0%> (-100%) ⬇️
lib/contfrac.gi 0% <0%> (-89.48%) ⬇️
grp/imf.gi 0% <0%> (-84.96%) ⬇️
lib/proto.gi 0% <0%> (-83.34%) ⬇️
lib/ctblauto.gi 0% <0%> (-82.41%) ⬇️
lib/ctbllatt.gi 0% <0%> (-80.72%) ⬇️
lib/teaching.g 2.45% <0%> (-77.15%) ⬇️
lib/algliess.gi 0% <0%> (-75.23%) ⬇️
... and 367 more

@olexandr-konovalov
Copy link
Member

thanks @fingolfin

@olexandr-konovalov olexandr-konovalov merged commit 018a2c5 into gap-system:master Jan 24, 2018
@olexandr-konovalov olexandr-konovalov deleted the mh/fix-IsPNilpotent branch January 24, 2018 12:35
@olexandr-konovalov olexandr-konovalov added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants