Fix a bug in the computation of a permutation group isomorphic to a group of automorphisms #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for n\ge 3. In the case of n=2 it needs to be considered as B2 instead. This fixes gap-system#1902 Added test
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
===========================================
+ Coverage 50.9% 63.62% +12.71%
===========================================
Files 438 946 +508
Lines 232007 283521 +51514
Branches 10446 12690 +2244
===========================================
+ Hits 118106 180386 +62280
+ Misses 111115 100351 -10764
+ Partials 2786 2784 -2
|
ChrisJefferson
approved these changes
Nov 15, 2017
| ## | ||
| #M AutomorphismGroup(<G>) . . abelian case | ||
| ## | ||
| InstallMethod(AutomorphismGroup,"test abelian",true,[IsGroup and IsFinite], |
There was a problem hiding this comment.
I've tested this PR on Jenkins, and tests pass. A minor remark is that the method's description "test abelian" does not seem to be enough informative. "for a finite group to enforce check of IsAbelian" maybe?
olexandr-konovalov
changed the title
|
@hulpke I've updated title to sound more informative in release notes. |
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1902