Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis CI badge for gap-docker-master-testsuite #1881

Closed
wants to merge 1 commit into from
Closed

Add Travis CI badge for gap-docker-master-testsuite #1881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[![Build Status](https://travis-ci.org/gap-system/gap.svg?branch=master)](https://travis-ci.org/gap-system/gap) [![Code Coverage](https://codecov.io/github/gap-system/gap/coverage.svg?branch=master&token=)](https://codecov.io/gh/gap-system/gap)
[![Build Status](https://travis-ci.org/gap-system/gap.svg?branch=master)](https://travis-ci.org/gap-system/gap) [![Build Status](https://travis-ci.org/gap-system/gap-docker-master-testsuite.svg?branch=master)](https://travis-ci.org/gap-system/gap-docker-master-testsuite) [![Code Coverage](https://codecov.io/github/gap-system/gap/coverage.svg?branch=master&token=)](https://codecov.io/gh/gap-system/gap)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unhappy that this makes two visually indistinguishable Travis badges appear. And worse, both have the same alt string "Build Status" -- so the only way to find out which is which is to check the URLs.

So the first change should be to use different "alt" strings, say "Build status" or "master branch status", versus e.g. "Docker build status".

Secondly, I'd strongly prefer if there also was an immediate visible clue as to which badge is is which. I don't know if the Travis badges allow that, but https://shields.io certainly does (and according to this blog post they are the source of Travis badges anyway?):

  • Default shield for gap-system/gap: master branch build status
  • Shield with custom label: master branch build status

There are other options (e.g. to adjust colors, styling etc.), describe on their homepage.


# What is GAP?

Expand Down