Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused oldmatint.gi #1765

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

markuspf
Copy link
Member

@markuspf markuspf commented Oct 5, 2017

No description provided.

@codecov
Copy link

codecov bot commented Oct 5, 2017

Codecov Report

Merging #1765 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1765      +/-   ##
==========================================
- Coverage   60.92%   60.92%   -0.01%     
==========================================
  Files         997      997              
  Lines      301952   301952              
  Branches    13037    13037              
==========================================
- Hits       183971   183970       -1     
+ Misses     115337   115334       -3     
- Partials     2644     2648       +4
Impacted Files Coverage Δ
src/stats.c 73.84% <0%> (-0.28%) ⬇️
src/objset.c 82.36% <0%> (-0.24%) ⬇️
src/hpc/thread.c 46.64% <0%> (-0.2%) ⬇️
src/hpc/traverse.c 78.29% <0%> (ø) ⬆️
src/funcs.c 71.82% <0%> (ø) ⬆️
src/gap.c 56.26% <0%> (+0.08%) ⬆️
src/system.c 52.02% <0%> (+0.33%) ⬆️

@ChrisJefferson
Copy link
Contributor

I had a google around (obviously not complete!) and I can't see anyone refering to this file, or using it, or including it in any code.

We should mention it is being removed in the release notes, maybe even giving a github reference to where you can get a copy of it? (Or say, grab it from a previous GAP version?)

@olexandr-konovalov
Copy link
Member

Instead of release notes, I suggest the DELETED file: https://github.com/gap-system/gap/blob/master/lib/DELETED

@markuspf
Copy link
Member Author

markuspf commented Oct 6, 2017

I am not so sure anymore that the DELETED file serves any purpose. One can just as well search in git's history (otherwise one has to know that this omnious DELETED file is there, etc).

@markuspf
Copy link
Member Author

markuspf commented Oct 6, 2017

@ChrisJefferson my impression was that the code in oldmatint.gi was integrated/superseded by intmat.gi. Maybe @stevelinton remembers something about this.

@olexandr-konovalov
Copy link
Member

@markuspf I'm fine if we delete the DELETED file (was you who created it in 55c6a02)

@ChrisJefferson ChrisJefferson merged commit 503ec0b into gap-system:master Oct 11, 2017
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Dec 14, 2017
@markuspf markuspf deleted the remove-oldmatint branch February 19, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants