fixed a bug in RadicalOfAlgebra
#1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For associative algebras that are not matrix algebras, the radical is computed in an isomorphic matrix algebra. Up to now, one ran into an error if `Coefficients` returned an immutable list. (One might argue that `Coefficients` should always return a new mutable list, but this would cause the creation of many superfluous lists. Thus we solve the problem in the place where the list has to be changed.)
Codecov Report
@@ Coverage Diff @@
## master #1716 +/- ##
==========================================
+ Coverage 64.44% 64.45% +<.01%
==========================================
Files 1002 1002
Lines 326714 326717 +3
Branches 13196 13217 +21
==========================================
+ Hits 210555 210584 +29
+ Misses 113302 113273 -29
- Partials 2857 2860 +3
|
fingolfin
added
the
kind: bug
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For associative algebras that are not matrix algebras,
the radical is computed in an isomorphic matrix algebra.
Up to now, this ran into an error if
Coefficientsreturned an immutable list.
This error was found because a recently (?) introduced bug
in the released version of GAP
(the one that caused
SolutionMat( [[ 1 ]], [ 1 ] )to returnfail--it is already fixed in the master branch)
triggered some code to be executed that was not used before.
(One might argue that
Coefficientsshould always returna new mutable list, but this would cause the creation of
many superfluous lists.
Thus we solve the problem in the place where the list
has to be changed.)