Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CodePcGroup for trivial pc group #1679

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Fix CodePcGroup for trivial pc group #1679

merged 1 commit into from
Sep 7, 2017

Conversation

wilfwilson
Copy link
Member

This PR resolves issue #1664. I don't really know about how this code works so perhaps my solution is bad in some way: I'm happy to find out.

fingolfin
fingolfin approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only request: Could you change the commit message to something like this:

randiso: fix CodePcGroup for trivial gp

Resolves #1664

That way, GitHub automatically closes the referenced issue once this PR is merged.

@wilfwilson
Copy link
Member Author

Cool, I didn't realise that. Done.

@markuspf markuspf merged commit 3af6a40 into gap-system:master Sep 7, 2017
@wilfwilson wilfwilson deleted the fix-issue-1664 branch September 7, 2017 09:40
@fingolfin fingolfin mentioned this pull request Sep 7, 2017
Closed
@olexandr-konovalov olexandr-konovalov added the gapdays2017-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2017-fall label Sep 7, 2017
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Jan 22, 2018
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@markuspf markuspf markuspf approved these changes

Assignees
No one assigned
Labels
gapdays2017-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2017-fall release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
GAP 4.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wilfwilson @fingolfin @markuspf @olexandr-konovalov