Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When printing function, reproduce TryNextMethod() correctly #1613

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

fingolfin
Copy link
Member

Before:

gap> Display(function() TryNextMethod(); end);
function (  )
    return TRY_NEXT_METHOD;
end

After:

gap> Display(function() TryNextMethod(); end);
function (  )
    TryNextMethod();
end

@codecov
Copy link

codecov bot commented Aug 22, 2017

Codecov Report

Merging #1613 into master will increase coverage by 14.48%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #1613       +/-   ##
===========================================
+ Coverage   49.52%   64.01%   +14.48%     
===========================================
  Files         456      998      +542     
  Lines      238345   327608    +89263     
  Branches    10654    13215     +2561     
===========================================
+ Hits       118044   209706    +91662     
+ Misses     117487   115045     -2442     
- Partials     2814     2857       +43
Impacted Files Coverage Δ
src/c_oper1.c 87.45% <ø> (+1.49%) ⬆️
hpcgap/src/c_oper1.c 86.18% <ø> (ø)
src/stats.c 73.2% <100%> (+1.9%) ⬆️
src/funcs.c 72.35% <0%> (-14.44%) ⬇️
src/blister.h 92% <0%> (-8%) ⬇️
src/objects.h 80% <0%> (-5.19%) ⬇️
src/plist.h 92.98% <0%> (-1.31%) ⬇️
src/dteval.c 2.79% <0%> (-0.29%) ⬇️
src/dt.c 1.61% <0%> (-0.26%) ⬇️
hpcgap/pkg/gapdoc/lib/GAPDoc2Text.gi 0.46% <0%> (-0.15%) ⬇️
... and 876 more

Before:
gap> Display(function() TryNextMethod(); end);
function (  )
    return TRY_NEXT_METHOD;
end

After:
gap> Display(function() TryNextMethod(); end);
function (  )
    TryNextMethod();
end
@ChrisJefferson ChrisJefferson merged commit fdaba7a into gap-system:master Aug 23, 2017
@fingolfin fingolfin deleted the mh/TryNextMethod branch August 23, 2017 10:15
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Jan 20, 2018
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants