Make structural copy handle Blists properly. #1455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Jun 26, 2017
| Obj copy; | ||
| Obj tmp; | ||
|
|
||
| copy = DoCopyBlist(list, mut); |
There was a problem hiding this comment.
Why is the declaration of the locals indented differently than the rest of the code? (For that matter: The other function you introduce indent by 2 spaces, this function by 4, mostly)
There was a problem hiding this comment.
Insufficiently clever emacs settings. Will fix
| @@ -334,7 +348,7 @@ void CleanBlistCopy ( | |||
| Obj list ) | |||
| { | |||
| /* remove the forwarding pointer */ | |||
| ADDR_OBJ(list)[0] = ADDR_OBJ( ADDR_OBJ(list)[0] )[0]; | |||
| ADDR_OBJ(list)[0] = ADDR_OBJ( ADDR_OBJ(list)[0] )[1]; | |||
There was a problem hiding this comment.
Shouldn't this be ADDR_OBJ(list)[0] = ELM_PLIST( ADDR_OBJ(list)[0], 1 ); ?
| @@ -312,7 +326,7 @@ Obj CopyBlistCopy ( | |||
| Obj list, | |||
| Int mut ) | |||
| { | |||
| return ADDR_OBJ(list)[0]; | |||
| return ADDR_OBJ(ADDR_OBJ(list)[0])[2]; | |||
There was a problem hiding this comment.
Shouldn't this be return ELM_PLIST( ADDR_OBJ(list)[0], 2 ); ?
Codecov Report
@@ Coverage Diff @@
## master #1455 +/- ##
==========================================
+ Coverage 63.79% 63.8% +<.01%
==========================================
Files 1009 1009
Lines 337592 337601 +9
Branches 13483 13473 -10
==========================================
+ Hits 215375 215392 +17
+ Misses 119253 119247 -6
+ Partials 2964 2962 -2
|
fingolfin
added
the
kind: enhancement
|
@stevelinton do you plan on updating this PR? Or should somebody else take it over? |
|
This has been superseded by #1514. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1428